[ 
https://issues.apache.org/jira/browse/CB-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227729#comment-14227729
 ] 

ASF GitHub Bot commented on CB-8092:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/94

    CB-8092 Adds support for encoded URIs to windows platform

    Fix for [CB-8092](https://issues.apache.org/jira/browse/CB-8092)
    * Adds `filesystem._format_()` method for windows which is common place to 
handle URI encoding.
    * Adds encoded URIs support to windows FileProxy methods

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-8092

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit a848f7d849146ab72d4cba45c958b99fbfb06271
Author: Vladimir Kotikov <[email protected]>
Date:   2014-11-27T15:11:05Z

    CB-8092 Adds support for encoded URIs to windows platform

----


> File plugin on windows doesn't encode URIs when using toUrl() method
> --------------------------------------------------------------------
>
>                 Key: CB-8092
>                 URL: https://issues.apache.org/jira/browse/CB-8092
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>            Reporter: Vladimir Kotikov
>              Labels: plugin-file, windows
>
> This can be reprod by file.spec.52
> {{Entry.toURL on directory: entryFile.toURL() return URL with “\\\” slashes 
> and non-encoded spaces in folder’s names}}
> This issue consists of 2 parts. First, windows is missing 
> {{filesystem.__format__()}} method which is common place to handle URI 
> encoding. Second, methods in FileProxy for windows can't handle encoded URIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to