[
https://issues.apache.org/jira/browse/CB-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227868#comment-14227868
]
ASF GitHub Bot commented on CB-8092:
------------------------------------
Github user vldmrrr commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-64818316
Hmm, looks like that PR's for windows file plugin keeps coming with
incremental changes proposed to current code base. I just wanted to bring to
everyones attention that there is an earlier PR CB-7883 with associated pull
request, that actually make the plugin on windows pass all current
crossplatform tests, and also makes it easy to plug additional file systems,
similar to other platforms - one of them, root (file:///) is already included.
Maybe it would be worth reviewing that code before taking divergent path.
> File plugin on windows doesn't encode URIs when using toUrl() method
> --------------------------------------------------------------------
>
> Key: CB-8092
> URL: https://issues.apache.org/jira/browse/CB-8092
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Reporter: Vladimir Kotikov
> Labels: plugin-file, windows
>
> This can be reprod by file.spec.52
> {{Entry.toURL on directory: entryFile.toURL() return URL with “\\\” slashes
> and non-encoded spaces in folder’s names}}
> This issue consists of 2 parts. First, windows is missing
> {{filesystem.__format__()}} method which is common place to handle URI
> encoding. Second, methods in FileProxy for windows can't handle encoded URIs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
