[
https://issues.apache.org/jira/browse/CB-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257320#comment-14257320
]
ASF GitHub Bot commented on CB-8043:
------------------------------------
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-67983624
Definitely some good changes here, but do have some feedback before this
goes any further:
1. There are many style-only changes in this commit. Style-only changes are
fine, but they should be done as separate commits from those that change
behaviour.
2. ConfigParser is meant to be a re-usable helper class that would be
useful outside the context of cordova-lib. Because of this, it shouldn't have
any require()s for modules from the rest of cordova-lib. That means no calls to
"events.emit". Validation should be done in the parsers. If parsers are
duplicating code a bunch, then we should refactor them to either share via a
common base class, or by having helper classes / modules that they all depend
on.
> Orientation preference's value set to anything but "landscape" or "portrait"
> doesn't work.
> ------------------------------------------------------------------------------------------
>
> Key: CB-8043
> URL: https://issues.apache.org/jira/browse/CB-8043
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Rémi Couturier
>
> cordova-cli: 4.1.2
> cordova-android: 3.6.4
> mac: osx yosemite
> In config.xml, setting the orientation preference's value to anything but
> "landscape" or "portrait" doesn't work. Complete list of possible value:
> http://developer.android.com/guide/topics/manifest/activity-element.html#screen
> For example when setting the value to "userLandscape" and building the app
> (cordova build android), I'm getting this message: "Unknown value for
> orientation preference: userLandscape".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
