[
https://issues.apache.org/jira/browse/CB-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262894#comment-14262894
]
ASF GitHub Bot commented on CB-8043:
------------------------------------
Github user MMrko commented on the pull request:
https://github.com/apache/cordova-lib/pull/128#issuecomment-68526026
Thanks for the feedback!
1. True, pardon my ignorance :) I removed the style-only changes
2. I moved the new functionality in to a separate [helper
module](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/helpers/).
The platform parsers now use this helper module by inheriting a [base
parser](/MMrko/cordova-lib/tree/fix-orientation-pref/cordova-lib/src/cordova/metadata/parser.js),
which the helper module extends
The platform parsers required the most refactoring. Previously the methods
in each platform parser were assigned in a way that overrode the prototype.
This needed to be refactored to allow the platform parsers to inherit from a
base parser without overriding it (see
918b47eba0308869b38a91a83055c26c15791bb6).
> Orientation preference's value set to anything but "landscape" or "portrait"
> doesn't work.
> ------------------------------------------------------------------------------------------
>
> Key: CB-8043
> URL: https://issues.apache.org/jira/browse/CB-8043
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android
> Reporter: Rémi Couturier
>
> cordova-cli: 4.1.2
> cordova-android: 3.6.4
> mac: osx yosemite
> In config.xml, setting the orientation preference's value to anything but
> "landscape" or "portrait" doesn't work. Complete list of possible value:
> http://developer.android.com/guide/topics/manifest/activity-element.html#screen
> For example when setting the value to "userLandscape" and building the app
> (cordova build android), I'm getting this message: "Unknown value for
> orientation preference: userLandscape".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
