[ 
https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270231#comment-14270231
 ] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/141#issuecomment-69271082
  
    @hstaudacher, I've added the remaining scenarios.
    
    I've copied over some of the changes you made in this branch and merged 
them with mine.
    I'd be grateful if you could review these changes:
    
    - 
https://github.com/MSOpenTech/cordova-lib/commit/c1135323c71e2f698e1a9f6fbcbf8d33274b1ff8
    - 
https://github.com/MSOpenTech/cordova-lib/commit/5d4e0e15b09a9cba60e2b5ee423ff528f40c398f
    - 
https://github.com/MSOpenTech/cordova-lib/commit/a8bdc8f7f87294ed8e984728efef7b9f86e9ad8b
    - 
https://github.com/MSOpenTech/cordova-lib/commit/c99eca2bb2712ffaa9a398a2ec48ed59091c072a
    



> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add 
> https://github.com/apache/cordova-android.git' and the git repo will be 
> cloned and used.
> - users can issue 'cordova platform add 
> android@https://github.com/apache/cordova-android.git' and the git repo will 
> be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file 
> contains: '<engine id='android' 
> version='https://github.com/apache/cordova-android.git' />, then the git repo 
> pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to