[ 
https://issues.apache.org/jira/browse/CB-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286193#comment-14286193
 ] 

ASF GitHub Bot commented on CB-8239:
------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/148#discussion_r23330749
  
    --- Diff: cordova-lib/spec-cordova/util.spec.js ---
    @@ -183,4 +184,138 @@ describe('util module', function() {
                 expect(res.indexOf('CVS')).toEqual(-1);
             });
         });
    +    describe('getPlatformDetailsFromDir function', function () {
    +
    +        var dir = 'C:\\Projects\\cordova-projects\\cordova-android';
    --- End diff --
    
    Unit Tests removed: 
https://github.com/MSOpenTech/cordova-lib/commit/f7ce4fb55aa55168023bbc62592c6323c81e6b8c


> Add support for git urls to 'cordova platform add'
> --------------------------------------------------
>
>                 Key: CB-8239
>                 URL: https://issues.apache.org/jira/browse/CB-8239
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>            Reporter: Omar Mefire
>
> Allow the following scenarios:
> - users can issue 'cordova platform add 
> https://github.com/apache/cordova-android.git' and the git repo will be 
> cloned and used.
> - users can issue 'cordova platform add 
> android@https://github.com/apache/cordova-android.git' and the git repo will 
> be cloned and used.
> - users can issue 'cordova platform add android' and if their config.xml file 
> contains: '<engine id='android' 
> version='https://github.com/apache/cordova-android.git' />, then the git repo 
> pointed to by config.xml will be cloned and used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to