[
https://issues.apache.org/jira/browse/CB-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276182#comment-14276182
]
ASF GitHub Bot commented on CB-8206:
------------------------------------
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905021
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
ROOT = path.join(__dirname, '..', '..'),
check_reqs = require('./check_reqs');
-
exports.createProject = function(project_path,package_name,project_name){
var VERSION = fs.readFileSync(path.join(ROOT, 'VERSION'), 'utf-8');
// Set default values for path, package and name
project_path = typeof project_path !== 'undefined' ? project_path :
"CordovaExample";
- package_name = typeof package_name !== 'undefined' ? package_name :
'org.apache.cordova.example';
--- End diff --
Turns out that `update` depends on `create`. As I mentioned in my pull
request, I had to remove these console.log messages as for the browser platform
we do not save the package and project name on creation. On upgrade, I do not
have a package and project name when I invoke `createProject`. These messages
had marginal value so I decided to remove them.
> Add support for browser platform update
> ---------------------------------------
>
> Key: CB-8206
> URL: https://issues.apache.org/jira/browse/CB-8206
> Project: Apache Cordova
> Issue Type: Bug
> Components: Browser
> Affects Versions: 3.5.0
> Reporter: Nikhil Khandelwal
>
> 'cordova update browser' is not supported.
> I have a fix for it and will shortly send out a pull request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
