[ 
https://issues.apache.org/jira/browse/CB-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277382#comment-14277382
 ] 

ASF GitHub Bot commented on CB-8206:
------------------------------------

Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r22957388
  
    --- Diff: node_modules/.bin/shjs ---
    @@ -1 +1,15 @@
    -../shelljs/bin/shjs
    --- End diff --
    
    Why are node_modules even checked in?  Shouldn't they just be added to 
.gitignore?  I double checked, and the only other cordova repo that checks 
these in is firefoxos, which I think is also an oversight.


> Add support for browser platform update
> ---------------------------------------
>
>                 Key: CB-8206
>                 URL: https://issues.apache.org/jira/browse/CB-8206
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Browser
>    Affects Versions: 3.5.0
>            Reporter: Nikhil Khandelwal
>
> 'cordova update browser' is not supported. 
> I have a fix for it and will shortly send out a pull request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to