[
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297799#comment-14297799
]
ASF GitHub Bot commented on CB-8123:
------------------------------------
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/155#issuecomment-72114968
The tests use path.join(), but jsproj uses hard-coded backslashes (which is
reasonable, because normally it would only run on Windows). This problem is
showing up now because previously this code wasn’t exercised by tests.
I’m looking to see if it is feasible/reasonable to update jsproj to be
platform agnostic, to the extent it needs to be for tests to pass. I’d prefer
that to skipping the tests, so we get consistent coverage (the tests don’t
build projects – just verify that files are modified as expected).
From: Jesse MacFadyen [mailto:[email protected]]
Sent: Thursday, January 29, 2015 12:12 PM
To: apache/cordova-lib
Cc: Tim Barham
Subject: Re: [cordova-lib] CB-8123 Plugin references can target specific
windows platforms. (#155)
You should use path.join( ) in your tests when creating paths so the tests
will still pass on MacOS, or check the environment and skip running your tests
altogether.
—
Reply to this email directly or view it on
GitHub<https://github.com/apache/cordova-lib/pull/155#issuecomment-72095389>.
> Enable version, device, and chip arch specific library / dll / winmd
> references in plugins for the Windows platform
> -------------------------------------------------------------------------------------------------------------------
>
> Key: CB-8123
> URL: https://issues.apache.org/jira/browse/CB-8123
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugins, Windows
> Reporter: Tim Barham
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Because Cordova's windows platform can target multiple target platforms,
> projects and frameworks referenced by the plugin may need to target only a
> subset of those platforms. To enable this, support the following attributes
> on the <lib-file> and <framework> elements:
> 1. device - indicates the reference is specific to a target device. Supported
> values are "phone", "windows" or "all" (default is "all").
> 2. versions - specify platform versions the reference supports (node semantic
> version ranges supported). Default is to support all versions.
> 3. arch - indicates the reference is specific to a particular chip
> architecture (x86 or x64).
> The "arch" attribute should result in a Condition="'$(Platform)'=='XXX"
> attribute on the reference. The other attributes will impact which generated
> jsproj files the reference is actually added to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
