[
https://issues.apache.org/jira/browse/CB-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315340#comment-14315340
]
ASF GitHub Bot commented on CB-8123:
------------------------------------
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/164
CB-8123 Plugin references can target specific windows platforms.
Adds support for `target`, `versions` and `arch` attributes on `<lib-file>`
and `<framework>` elements in the windows platform of plugin.xml. This allows
plugin authors to target different references to different target platforms.
Also adds support for `src` attribute as an alias for the `Include`
attribute on the `
<lib-file>` element (since `src` is documented, but `Include` is used by
existing plugins).
Adds some tests to cover the new attributes. Updates existing plugin tests
for windows8 platform to also test windows platform (left in windows8 tests to
help verify backward compatibility with old windows8 platform).
As part of this change, refactored `jsproj` to `jsprojManager` to reflect
the fact that, with the windows platform, this class now manages multiple
jsproj files.
Broken into three commits to separate file renames from changes, so that
git can successfully track the changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #164
----
commit 94efb46eccbe0438dbede35b90c4c2255dac0b77
Author: Tim Barham <[email protected]>
Date: 2015-02-11T00:53:36Z
CB-8123 Plugin references can target specific windows platforms.
Adds support for `target`, `versions` and `arch` attributes on `<lib-file>`
and `<framework>` elements in the windows platform of plugin.xml. This allows
plugin authors to target different references to different target platforms.
Also adds support for `src` attribute as an alias for the `Include`
attribute on the `
<lib-file>` element (since `src` is documented, but `Include` is used by
existing plugins).
Adds some tests to cover the new attributes. Updates existing plugin tests
for windows8 platform to also test windows platform (left in windows8 tests to
help verify backward compatibility with old windows8 platform).
As part of this change, refactored `jsproj` to `jsprojManager` to reflect
the fact that, with the windows platform, this class now manages multiple
jsproj files.
I will rename some windows8 files and folders to windows, and jsproj.js to
jsprojManager.js in a subsequent commit.
commit d7a09785bde58d11136653685c08ad148c1ae189
Author: Tim Barham <[email protected]>
Date: 2015-02-11T01:11:40Z
CB-8123 Rename windows platform related files.
Renames `windows8` plugin platform folders in tests to `windows`. Renames
`jsproj.js` to `jsprojManager.js`.
commit 5b31cecf7677a53279ded52158dd3a6ea57d379c
Author: Tim Barham <[email protected]>
Date: 2015-02-11T01:12:53Z
CB-8123 Rename further windows platform related files.
Renames `windows8.spec.js` to `windows.spec.js`.
----
> Enable version, device, and chip arch specific library / dll / winmd
> references in plugins for the Windows platform
> -------------------------------------------------------------------------------------------------------------------
>
> Key: CB-8123
> URL: https://issues.apache.org/jira/browse/CB-8123
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugins, Windows
> Reporter: Tim Barham
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Because Cordova's windows platform can target multiple target platforms,
> projects and frameworks referenced by the plugin may need to target only a
> subset of those platforms. To enable this, support the following attributes
> on the <lib-file> and <framework> elements:
> 1. device - indicates the reference is specific to a target device. Supported
> values are "phone", "windows" or "all" (default is "all").
> 2. versions - specify platform versions the reference supports (node semantic
> version ranges supported). Default is to support all versions.
> 3. arch - indicates the reference is specific to a particular chip
> architecture (x86 or x64).
> The "arch" attribute should result in a Condition="'$(Platform)'=='XXX"
> attribute on the reference. The other attributes will impact which generated
> jsproj files the reference is actually added to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
