[ https://issues.apache.org/jira/browse/CB-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388114#comment-14388114 ]
ASF GitHub Bot commented on CB-8768: ------------------------------------ GitHub user thehuijb opened a pull request: https://github.com/apache/cordova-android/pull/171 solves CB-8768 issue where onActivityResult gets called before onResume after MainActivity gets killed situation: one of the plugins launches startActivityForResult and the Android OS decides to kill our MainActivity. once the launched activity is fulfilled it comes back to our MainActivity, which has to be recreated first. unfortunately Android calls onActivityResult before our Activity has fully loaded our installed plugins. this commit fixes that issue. thanks to suggestions by Andrew Grieve You can merge this pull request into a Git repository by running: $ git pull https://github.com/thehuijb/cordova-android develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 ---- commit a9d0a6f133f049807ad796b11b0f3e13644725c7 Author: Serge Huijben <s.huij...@gmail.com> Date: 2015-03-31T06:28:13Z solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after MainActivity gets killed situation: one of the plugins launches startActivityForResult and the Android OS decides to kill our MainActivity. once the launched activity is fulfilled it comes back to our MainActivity, which has to be recreated first. unfortunately Android calls onActivityResult before our Activity has fully loaded our installed plugins. this commit fixes that issue. thanks to suggestions by Andrew Grieve commit dceddf3c4e254c1649ddd376e8ff33db822adaca Author: Serge Huijben <s.huij...@gmail.com> Date: 2015-03-31T06:28:13Z solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after MainActivity gets killed situation: one of the plugins launches startActivityForResult and the Android OS decides to kill our MainActivity. once the launched activity is fulfilled it comes back to our MainActivity, which has to be recreated first. unfortunately Android calls onActivityResult before our Activity has fully loaded our installed plugins. this commit fixes that issue. thanks to suggestions by Andrew Grieve commit 4ca329d5bf09ebbc8e4dd090aa5a663acb65df6c Author: Serge Huijben <s.huij...@gmail.com> Date: 2015-03-31T06:29:40Z Merge branch 'develop' of https://github.com/thehuijb/cordova-android into develop * 'develop' of https://github.com/thehuijb/cordova-android: solves CB-8768 issue where onActivityResult while plugins are not yet fully loaded after MainActivity gets killed ---- > if MainActivity is killed by Android OS after a plugin started a new activity > onActivityResult gets called before the plugin needed to handle the result is > loaded > ------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > Key: CB-8768 > URL: https://issues.apache.org/jira/browse/CB-8768 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Reporter: Serge Huijben > > if one of the plugins launches startActivityForResult and the Android OS > decides to kill our MainActivity. what happens when the launched activity is > closed. > the previous activity (our MainActivity is relaunched and onActivityResult is > called, our mainActivity however has not yet had the time to load all > onload=true plugins so therefore the savedInstanceState callBackService can > not be called. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org