[
https://issues.apache.org/jira/browse/CB-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388561#comment-14388561
]
ASF GitHub Bot commented on CB-8768:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27481986
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState) {
public void restoreInstanceState(Bundle savedInstanceState) {
initCallbackService =
savedInstanceState.getString("callbackService");
}
+
+ private class ActivityResultHolder {
+
+ private int requestCode;
+ private int resultCode;
+ private Intent intent;
+
+ public ActivityResultHolder(int requestCode, int resultCode,
Intent intent) {
+ this.requestCode = requestCode;
+ this.resultCode = resultCode;
+ this.intent = intent;
+ }
+
+ public int getRequestCode() {
--- End diff --
nit: no point in creating getters for a private class
> if MainActivity is killed by Android OS after a plugin started a new activity
> onActivityResult gets called before the plugin needed to handle the result is
> loaded
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-8768
> URL: https://issues.apache.org/jira/browse/CB-8768
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Serge Huijben
>
> if one of the plugins launches startActivityForResult and the Android OS
> decides to kill our MainActivity. what happens when the launched activity is
> closed.
> the previous activity (our MainActivity is relaunched and onActivityResult is
> called, our mainActivity however has not yet had the time to load all
> onload=true plugins so therefore the savedInstanceState callBackService can
> not be called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
