[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559625#comment-14559625
]
ASF GitHub Bot commented on CB-8954:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/142#discussion_r31067211
--- Diff: bin/lib/check_reqs.js ---
@@ -17,34 +17,30 @@
under the License.
*/
-/* jshint node:true, bitwise:true, undef:true, trailing:true,
quotmark:true,
- indent:4, unused:vars, latedef:nofunc,
- sub:true, laxcomma:true, laxbreak:true
-*/
-
var Q = require('q'),
- os = require('os'),
shell = require('shelljs'),
versions = require('./versions');
var XCODEBUILD_MIN_VERSION = '4.6.0';
+var XCODEBUILD_NOT_FOUND_MESSAGE =
+ 'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from
App Store';
var IOS_SIM_MIN_VERSION = '3.0.0';
-var IOS_SIM_NOT_FOUND_MESSAGE = 'ios-sim was not found. Please download,
build and install version ' + IOS_SIM_MIN_VERSION +
- ' or greater from https://github.com/phonegap/ios-sim into your path.'
+
- ' Or \'npm install -g ios-sim\' using node.js: http://nodejs.org';
+var IOS_SIM_NOT_FOUND_MESSAGE =
+ 'Please download, build and install version ' + IOS_SIM_MIN_VERSION +
' or greater' +
+ ' from https://github.com/phonegap/ios-sim into your path, or do \'npm
install -g ios-sim\'';
--- End diff --
Remove 'do' (or add it to `IOS_DEPLOY_NOT_FOUND_MESSAGE`).
> Update platform check_reqs script to return structured result to
> 'requirements' command
> ---------------------------------------------------------------------------------------
>
> Key: CB-8954
> URL: https://issues.apache.org/jira/browse/CB-8954
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Windows, WP8
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> Since {{requirements}} LIB method assumes that underlying platform script
> will be {{require}}d instead of spawning child process and capturing output,
> we need to modify these scripts to provide method that will be called for
> getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
