[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559627#comment-14559627
]
ASF GitHub Bot commented on CB-8954:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/142#discussion_r31067511
--- Diff: bin/lib/check_reqs.js ---
@@ -75,20 +78,74 @@ module.exports.help = function () {
* @return {Promise} Returns a promise either resolved with tool
version or rejected
*/
function checkTool (tool, minVersion, optMessage) {
- if (os.platform() !== 'darwin'){
- // Build iOS apps available for OSX platform only, so we reject on
others platforms
- return Q.reject('Cordova tooling for iOS requires Apple OS X');
- }
// Check whether tool command is available at all
var tool_command = shell.which(tool);
if (!tool_command) {
- return Q.reject(optMessage || (tool + 'command is unavailable.'));
+ return Q.reject(tool + ' was not found. ' + (optMessage || ''));
--- End diff --
I presume the `opt` in `optMessage` stands for 'optional` - it's not longer
really optional, so perhaps change the name?
> Update platform check_reqs script to return structured result to
> 'requirements' command
> ---------------------------------------------------------------------------------------
>
> Key: CB-8954
> URL: https://issues.apache.org/jira/browse/CB-8954
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, iOS, Windows, WP8
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> Since {{requirements}} LIB method assumes that underlying platform script
> will be {{require}}d instead of spawning child process and capturing output,
> we need to modify these scripts to provide method that will be called for
> getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
