[
https://issues.apache.org/jira/browse/CB-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578555#comment-14578555
]
ASF GitHub Bot commented on CB-9127:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/238#discussion_r31991342
--- Diff: cordova-serve/src/platform.js ---
@@ -0,0 +1,55 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var server = require('./server'),
+ fs = require('fs'),
+ util = require('./util');
+
+/**
+ * Launches a server where the root points to the specified platform in a
Cordova project.
+ * @param {string} platform - Cordova platform to serve.
+ * @param {{root: ?string, port: ?number, urlPathProcessor: ?function,
streamHandler: ?function, serverExtender: ?function}} opts
+ * root - cordova project directory, or any directory within it. If not
specified, cwd is used. This will be modified to point to the platform's
www_dir.
+ * All other values are passed unaltered to launchServer().
+ * @returns {*|promise}
+ */
+module.exports = function (platform, opts) {
+ if (!platform) {
--- End diff --
It would be better to wrap function into `Q.when()` to return a promise
even if error is thrown. Otherwise you'll need to wrap this code into
`try...catch` in caller code.
> Implement cordova-serve module
> ------------------------------
>
> Key: CB-9127
> URL: https://issues.apache.org/jira/browse/CB-9127
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Browser, CordovaLib
> Reporter: Tim Barham
> Assignee: Tim Barham
>
> The `cordova serve` command provided by `cordova-lib`, and `cordova run
> browser` provided `cordova-browser` both provide basic server functionality
> that is duplicated in two places. We should combine this into a single
> `cordova-serve` module that can be used by both.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
