[
https://issues.apache.org/jira/browse/CB-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578579#comment-14578579
]
ASF GitHub Bot commented on CB-9127:
------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/238#discussion_r31992378
--- Diff: cordova-serve/src/browser.js ---
@@ -0,0 +1,100 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var exec = require('./exec'),
+ Q = require('q');
+
+/**
+ * Launches the specified browser with the given URL.
+ * Based on https://github.com/domenic/opener
+ * @param {{target: ?string, url: ?string, dataDir: ?string}} opts -
parameters:
+ * target - the target browser - ie, chrome, safari, opera, firefox or
chromium
+ * url - the url to open in the browser
+ * dataDir - a data dir to provide to Chrome (can be used to force it to
open in a new window)
+ * @return {Q} Promise to launch the specified browser
+ */
+module.exports = function (opts) {
+ //target, url, dataDir
+ var target = opts.target || 'chrome';
+ var url = opts.url || '';
+
+ return mapTarget(target, opts.dataDir).then(function (browser) {
--- End diff --
nit: it might sounds better if the function is called `getBrowser`
> Implement cordova-serve module
> ------------------------------
>
> Key: CB-9127
> URL: https://issues.apache.org/jira/browse/CB-9127
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Browser, CordovaLib
> Reporter: Tim Barham
> Assignee: Tim Barham
>
> The `cordova serve` command provided by `cordova-lib`, and `cordova run
> browser` provided `cordova-browser` both provide basic server functionality
> that is duplicated in two places. We should combine this into a single
> `cordova-serve` module that can be used by both.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
