[ 
https://issues.apache.org/jira/browse/CB-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579250#comment-14579250
 ] 

ASF GitHub Bot commented on CB-9127:
------------------------------------

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/238#discussion_r32038377
  
    --- Diff: cordova-serve/src/server.js ---
    @@ -0,0 +1,137 @@
    +/**
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    + http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    + */
    +
    +var fs     = require('fs'),
    +    http   = require('http'),
    +    url    = require('url'),
    +    path   = require('path'),
    +    Q      = require('q'),
    +    stream = require('./stream');
    +
    +/**
    + * @desc Launches a server with the specified options and optional custom 
handlers.
    + * @param {{root: ?string, port: ?number, urlPathProcessor: ?function, 
streamHandler: ?function, serverExtender: ?function}} opts
    --- End diff --
    
    Done.


> Implement cordova-serve module
> ------------------------------
>
>                 Key: CB-9127
>                 URL: https://issues.apache.org/jira/browse/CB-9127
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Browser, CordovaLib
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>
> The `cordova serve` command provided by `cordova-lib`, and `cordova run 
> browser` provided `cordova-browser` both provide basic server functionality 
> that is duplicated in two places. We should combine this into a single 
> `cordova-serve` module that can be used by both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to