[
https://issues.apache.org/jira/browse/CB-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580038#comment-14580038
]
ASF GitHub Bot commented on CB-9147:
------------------------------------
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/244#discussion_r32088895
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -360,6 +360,12 @@ function getPluginVariables(variables){
function getVersionFromConfigFile(plugin, cfg){
var pluginEntry = cfg.getPlugin(plugin);
+ if (!pluginEntry) {
+ var oldStylePluginId = pluginMapper[plugin];
+ if (oldStylePluginId) {
--- End diff --
'oldStylePluginId' is not the correct name for what the registry-mapper
(pluginMapper) returns. it returns the package name, which is the new way of
doing things. so, I'd call it something like 'packageName' ..
> Adding a platform with a caret version adds the very latest rather than the
> latest matching version
> ---------------------------------------------------------------------------------------------------
>
> Key: CB-9147
> URL: https://issues.apache.org/jira/browse/CB-9147
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 5.0.0
> Reporter: Tim Barham
> Assignee: Tim Barham
>
> If you add, say, windows 3.5.0 platform to a project with the save flag:
> {noformat}
> cordova platform add [email protected] --save
> {noformat}
> We write out {{^3.5.0}} to {{config.xml}}.
> If the platform is removed then re-added, we install {{4.0.0}} instead of the
> expected {{3.8.2}}.
> This is because internally we are using a version of {{npm}} that doesn't
> understand caret versions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
