[ 
https://issues.apache.org/jira/browse/CB-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580177#comment-14580177
 ] 

ASF GitHub Bot commented on CB-9147:
------------------------------------

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/244#discussion_r32094913
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -360,6 +360,12 @@ function getPluginVariables(variables){
     
     function getVersionFromConfigFile(plugin, cfg){
         var pluginEntry = cfg.getPlugin(plugin);
    +    if (!pluginEntry) {
    +        var oldStylePluginId = pluginMapper[plugin];
    +        if (oldStylePluginId) {
    --- End diff --
    
    Nope, it really is oldStylePluginId... Have a look at the declaration of 
pluginMapper.


> Adding a platform with a caret version adds the very latest rather than the 
> latest matching version
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CB-9147
>                 URL: https://issues.apache.org/jira/browse/CB-9147
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.0.0
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>
> If you add, say, windows 3.5.0 platform to a project with the save flag:
> {noformat}
> cordova platform add [email protected] --save
> {noformat}
> We write out {{^3.5.0}} to {{config.xml}}.
> If the platform is removed then re-added, we install {{4.0.0}} instead of the 
> expected {{3.8.2}}.
> This is because internally we are using a version of {{npm}} that doesn't 
> understand caret versions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to