[
https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581672#comment-14581672
]
ASF GitHub Bot commented on CB-9158:
------------------------------------
Github user syndbg commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#discussion_r32199198
--- Diff: src/android/InAppBrowser.java ---
@@ -656,7 +647,7 @@ public void onClick(View v) {
WebSettings settings = inAppWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setJavaScriptCanOpenWindowsAutomatically(true);
- settings.setBuiltInZoomControls(getShowZoomControls());
+ settings.setBuiltInZoomControls(showZoomControls);
--- End diff --
here's the issue
> InAppBrowser zoomControls are always set to true
> ------------------------------------------------
>
> Key: CB-9158
> URL: https://issues.apache.org/jira/browse/CB-9158
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 3.5.0
> Environment: Latest InAppBrowser
> https://github.com/apache/cordova-plugin-inappbrowser, any Android device
> Reporter: Anton Antonov
> Labels: easyfix, patch
>
> InAppBrowser does not respect the passed options string to *window.open*.
> *location=no* or *location=yes* will never make a difference due to source
> code always assuming it's boolean true.
> Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104
> P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
