[
https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590781#comment-14590781
]
ASF GitHub Bot commented on CB-9158:
------------------------------------
Github user syndbg commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072
@purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted
the wrong option parameter, `location`, when in fact I meant `zoom`.
This PR fixes `zoom=true` or `zoom=false` not making a difference in the
android app.
Can we agree on the fact that fixing (in my opinion) non-formatted code,
even in the iOS section of the plugin, should not be a blocker to merge this
PR.
> InAppBrowser zoomControls are always set to true
> ------------------------------------------------
>
> Key: CB-9158
> URL: https://issues.apache.org/jira/browse/CB-9158
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 3.5.0
> Environment: Latest InAppBrowser
> https://github.com/apache/cordova-plugin-inappbrowser, any Android device
> Reporter: Anton Antonov
> Labels: easyfix, patch
>
> InAppBrowser does not respect the passed options string to *window.open*.
> *zoom=no* or *zoom=yes* will never make a difference due to source code
> always assuming it's boolean true.
> Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104
> P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
