[ 
https://issues.apache.org/jira/browse/CB-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588425#comment-14588425
 ] 

ASF GitHub Bot commented on CB-8197:
------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/146#discussion_r32547846
  
    --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
    @@ -374,7 +374,7 @@
                        );
                        runOnlyForDeploymentPostprocessing = 0;
                        shellPath = /bin/sh;
    -                   shellScript = "cordova/lib/copy-www-build-step.sh";
    +                   shellScript = "node cordova/lib/copy-www-build-step.js";
    --- End diff --
    
    I thought about this earlier when the PR came in and I think its a good 
assumption since it's a Cordova project and the user is using the CLI. The 
scenario where a user would take the project from platforms/ios and run it 
stand-alone is miniscule. 
    
    Not sure if this is supported fully but Xcode.app does include node.js 
under `/Applications/Xcode.app/Contents/Developer/usr/share/xcs/Node/bin/node`
    
    You would dynamically get this path by using `xcode-select --print-path` 
then appending `/usr/share/xcs/Node/bin/node`
    
    



> Switch to nodejs for ios platform scripts
> -----------------------------------------
>
>                 Key: CB-8197
>                 URL: https://issues.apache.org/jira/browse/CB-8197
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Vladimir Kotikov
>             Fix For: 3.8.0
>
>
> Currently platform tooling for ios is based on bash scripts and to improve 
> maintainability of such scripts it would be useful to port them to NodeJS.
> Part of this work is already done for create/update scripts in 
> https://issues.apache.org/jira/browse/CB-5706 but platform scripts placed in 
> cordova folder of platform is still being unported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to