[
https://issues.apache.org/jira/browse/CB-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592221#comment-14592221
]
ASF GitHub Bot commented on CB-8197:
------------------------------------
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32759726
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cordova/lib/copy-www-build-step.sh";
+ shellScript = "node cordova/lib/copy-www-build-step.js";
--- End diff --
+1 The cli dependent on node, so it makes sense to require it in the path.
Does this affect users who are not using the cli? Probably still not a big
deal either way.
> Switch to nodejs for ios platform scripts
> -----------------------------------------
>
> Key: CB-8197
> URL: https://issues.apache.org/jira/browse/CB-8197
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Reporter: Vladimir Kotikov
> Fix For: 3.8.0
>
>
> Currently platform tooling for ios is based on bash scripts and to improve
> maintainability of such scripts it would be useful to port them to NodeJS.
> Part of this work is already done for create/update scripts in
> https://issues.apache.org/jira/browse/CB-5706 but platform scripts placed in
> cordova folder of platform is still being unported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
