[
https://issues.apache.org/jira/browse/CB-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605838#comment-14605838
]
ASF GitHub Bot commented on CB-9238:
------------------------------------
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481751
--- Diff: src/windows/MediaProxy.js ---
@@ -159,7 +176,21 @@ module.exports = {
var id = args[0];
var src = args[1];
- var normalizedSrc = src.replace(/\//g, '\\');
+ src = setTemporaryFsByDefault(src);
+
+ var success = function () {
+ Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_RUNNING);
+ win();
+ };
+
+ var error = function (reason) {
+ Media.onStatus(id, Media.MEDIA_ERROR, reason);
+ lose(reason);
+ };
+
+ // Fixing paths like: ms-appdata:///temp//recs/memos/media.m4a =>
ms-appdata:///temp/recs/memos/media.m4a
+ var normalizedSrc = src.replace(/([^\/])(\/\/)([^\/])/g, '$1/$3');
--- End diff --
This is another instance in which using Windows.Foundation.Uri may be
preferable. You can canonicalize the Uri using it, instead of worrying about
doing accurate regular expression matching. See for example
https://msdn.microsoft.com/en-us/library/windows/apps/windows.foundation.uri.absolutecanonicaluri.aspx
> Media plugin cannot record audio on windows
> -------------------------------------------
>
> Key: CB-9238
> URL: https://issues.apache.org/jira/browse/CB-9238
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media, Windows
> Reporter: Alexander Sorokin
>
> Steps to reproduce:
> - create mobile spec app with media plugin
> - run mobile spec app on windows store or windows phone
> - go to media manual tests
> - click "Record Audio 10 sec"
> The result is: RecordAudio():Audio Error: 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
