[ 
https://issues.apache.org/jira/browse/CB-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605855#comment-14605855
 ] 

ASF GitHub Bot commented on CB-9238:
------------------------------------

Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482157
  
    --- Diff: src/windows/MediaProxy.js ---
    @@ -203,20 +234,64 @@ module.exports = {
             var id = args[0];
             var thisM = Media.get(id);
     
    -        var normalizedSrc = thisM.src.replace(/\//g, '\\');
    +        var success = function () {
    +            Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_STOPPED);
    +            win();
    +        };
    +
    +        var error = function (reason) {
    +            Media.onStatus(id, Media.MEDIA_ERROR, reason);
    +            lose(reason);
    +        };
    +
    +        var fsTypes = {
    +            PERSISTENT: 'PERSISTENT',
    +            TEMPORARY: 'TEMPORARY'
    +        };
    +        var fsType;
    +
    +        var normalizedSrc = thisM.src;
    +        normalizedSrc = setTemporaryFsByDefault(normalizedSrc);
    +
    +        if (normalizedSrc.indexOf('ms-appdata:///local/') === 0) {
    +            fsType = fsTypes.PERSISTENT;
    +        } else if (normalizedSrc.indexOf('ms-appdata:///temp/') === 0) {
    +            fsType = fsTypes.TEMPORARY;
    +        } else {
    +            lose({ code: MediaError.MEDIA_ERR_NONE_SUPPORTED });
    +            return;
    +        }
    +
    +        // Removing schemes (both variants are supported)
    +        normalizedSrc = normalizedSrc.replace('ms-appdata:///local//', 
'').replace('ms-appdata:///temp//', '')
    --- End diff --
    
    Seems like as per line 192 you don't need these top two variations.  


> Media plugin cannot record audio on windows
> -------------------------------------------
>
>                 Key: CB-9238
>                 URL: https://issues.apache.org/jira/browse/CB-9238
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media, Windows
>            Reporter: Alexander Sorokin
>
> Steps to reproduce:
> - create mobile spec app with media plugin
> - run mobile spec app on windows store or windows phone
> - go to media manual tests
> - click "Record Audio 10 sec"
> The result is: RecordAudio():Audio Error: 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to