[
https://issues.apache.org/jira/browse/CB-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694290#comment-14694290
]
ASF GitHub Bot commented on CB-9482:
------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36921320
--- Diff: template/cordova/lib/deployment.js ---
@@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices =
function() {
});
};
+// Note: To account for CB-9482, we pass an extra parameter when retrying
the call. Be forwarned to check for that
+// if additional parameters are added in the future.
AppDeployCmdTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
var command = shouldUpdate ? '/update' : '/install';
if (shouldLaunch) {
command += 'launch';
}
- return run(this.path, [command, pathToAppxPackage, '/targetdevice:' +
targetDevice.__shorthand]);
+ var that = this;
+ var result = run(this.path, [command, pathToAppxPackage,
'/targetdevice:' + targetDevice.__shorthand]);
+ if (targetDevice.type === 'emulator' && arguments.length < 6) {
+ result = result.then(null, function(e) {
+ // CB-9482: AppDeployCmd also reports E_INVALIDARG during this
process. If so, try to repeat.
+ if (e.code === 2147942487) {
--- End diff --
Nitpick: Please define this as a constant.
> Uninstall succeeds but reports failure when acted on the Win8.1 Phone Emulator
> ------------------------------------------------------------------------------
>
> Key: CB-9482
> URL: https://issues.apache.org/jira/browse/CB-9482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic, Windows
> Reporter: Rob Paveza
> Assignee: Rob Paveza
> Priority: Minor
> Labels: found-by-ci
>
> The underlying AppDeployCmd /uninstall {app-guid} /targetdevice:{emulator ID}
> succeeds in uninstalling an app if it is installed, but reports a failure.
> This results in not trying to install the app subsequently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
