[
https://issues.apache.org/jira/browse/CB-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694380#comment-14694380
]
ASF GitHub Bot commented on CB-9482:
------------------------------------
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/113#discussion_r36925416
--- Diff: template/cordova/lib/deployment.js ---
@@ -35,7 +35,7 @@ function run(cmd, args, opt_cwd) {
child.stderr.on('data', function(s) { stderr += s; });
child.on('exit', function(code) {
if (code) {
- d.reject(stderr);
+ d.reject({ message: stderr, code: code, toString:
function() { return stderr; }});
--- End diff --
This isn't logging. This is providing an object instead of a string to the
failure case of a promise.
> Uninstall succeeds but reports failure when acted on the Win8.1 Phone Emulator
> ------------------------------------------------------------------------------
>
> Key: CB-9482
> URL: https://issues.apache.org/jira/browse/CB-9482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Medic, Windows
> Reporter: Rob Paveza
> Assignee: Rob Paveza
> Priority: Minor
> Labels: found-by-ci
>
> The underlying AppDeployCmd /uninstall {app-guid} /targetdevice:{emulator ID}
> succeeds in uninstalling an app if it is installed, but reports a failure.
> This results in not trying to install the app subsequently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
