[ 
https://issues.apache.org/jira/browse/CB-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700743#comment-14700743
 ] 

Shazron Abdullah commented on CB-8047:
--------------------------------------

I like the active approach like you described versus the passive one that we 
had. 

cordova-ios CDVViewController already implements CDVScreenOrientationDelegate 
-- instead we could make the delegate a property on CDVViewController, then 
create an included plugin that implements CDVScreenOrientationDelegate but also 
is set as the orientation delegate for CDVViewController. This included plugin 
can then handle the JavaScript interface you described. This new plugin will 
also handle any orientation code that currently exists in CDVViewController 
(basically move all the orientation code there).

Users however will have to wait for the success callback from setting the 
orientation before seeing the effect, however. This might be undesirable during 
the duration of the call, not sure of the visual impact yet, will have to test 
it out. It might just be fast enough to not make a difference.



> [WKWebView][iOS8] wkwebview / local webserver plugin orientation issue
> ----------------------------------------------------------------------
>
>                 Key: CB-8047
>                 URL: https://issues.apache.org/jira/browse/CB-8047
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>         Environment: IOS
>            Reporter: Dustin Nielson
>            Assignee: Shazron Abdullah
>             Fix For: 4.0.0
>
>
> After installing the `wkwebview-engine` plugin on ios device (tested iPhone 
> 6, iPad mini 2, iPad retina) and enabling all orientations in xcode.  Upon 
> successful build the devices have fixed portrait orientation that doesn't 
> change when device is rotated.
> The `wkwebview` branch of cordova-ios was used. This problem does not occur 
> in the `master` branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to