[
https://issues.apache.org/jira/browse/CB-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978876#comment-14978876
]
ASF GitHub Bot commented on CB-9872:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43292467
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
console.log(err);
expect(false).toBe(true);
done();
+ }).finally(function () {
+ revertDownloadPlatform();
});
- }, timeout);
+ }, TIMEOUT);
it('spec.11 should update spec with git url when updating using
git url', function (done) {
helpers.setEngineSpec(appPath, platformName,
platformVersionNew);
- platform('add', platformName + '@' + platformVersionNew)
+ mockDownloadPlatform(platformLocalPathOld, platformVersionOld);
+
+ platform('add', platformName + '@' + platformVersionOld)
.then(function () {
+ revertDownloadPlatform();
var fsExistsSync = fs.existsSync.bind(fs);
spyOn(fs, 'existsSync').andCallFake(function (somePath) {
return (somePath === path.join(appPath, 'platforms',
platformName)) || fsExistsSync(somePath);
});
+ mockDownloadPlatform(platformLocalPathNew,
platformVersionNew);
--- End diff --
Using edge for this test has caught 2 `cordova-android` issues in the last
week or so. While ideally we don't want `cordova-lib` tests failing because of
`cordova-android` issues, should we continue using edge in these tests until
we've added `update` tests to `cordova-android`?
> cordova-lib unit-test failure
> -----------------------------
>
> Key: CB-9872
> URL: https://issues.apache.org/jira/browse/CB-9872
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Assignee: Alexander Sorokin
> Priority: Critical
> Labels: cordova-ios-4.0.x
>
> {code}
> Failures:
> 1) (save flag) platform update --save spec.11 should update spec with git
> url when updating using git url
> Message:
> Expected false to be true.
> Stacktrace:
> Error: Expected false to be true.
> at
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-cordova/save.spec.js:266:31
> at _rejected
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:797:24)
> at
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:823:30
> at Promise.when
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:1035:31)
> at Promise.promise.promiseDispatch
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:741:41)
> at
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (node.js:355:11)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
