[ 
https://issues.apache.org/jira/browse/CB-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979442#comment-14979442
 ] 

ASF GitHub Bot commented on CB-9872:
------------------------------------

Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-lib/pull/332#issuecomment-152024899
  
    @stevengill  - ultimately, the point of these tests is to test the `--save` 
feature, so going forward I don't think we want them to be at risk of being 
broken by platform changes in master, as long as we add tests to the platforms 
that cover the e2e scenarios that these tests were "accidentally" covering.


> cordova-lib unit-test failure
> -----------------------------
>
>                 Key: CB-9872
>                 URL: https://issues.apache.org/jira/browse/CB-9872
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Alexander Sorokin
>            Priority: Critical
>              Labels: cordova-ios-4.0.x
>
> {code}
> Failures:
>   1) (save flag) platform update --save spec.11 should update spec with git 
> url when updating using git url
>    Message:
>      Expected false to be true.
>    Stacktrace:
>      Error: Expected false to be true.
>     at 
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/spec-cordova/save.spec.js:266:31
>     at _rejected 
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:797:24)
>     at 
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:823:30
>     at Promise.when 
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:1035:31)
>     at Promise.promise.promiseDispatch 
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:741:41)
>     at 
> /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
>     at flush 
> (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
>     at process._tickCallback (node.js:355:11)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to