[ 
https://issues.apache.org/jira/browse/CB-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047967#comment-15047967
 ] 

ASF GitHub Bot commented on CB-10162:
-------------------------------------

Github user csantanapr commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/182#discussion_r47048069
  
    --- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
    @@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) {
             return updateProject(self._config, self.locations);
         })
         .then(function () {
    -        handleIcons(cordovaProject.projectConfig, self.root);
    -        handleSplashScreens(cordovaProject.projectConfig, self.root);
    +        handleIcons(cordovaProject.projectConfig, self.root, 
self.locations);
    --- End diff --
    
    @eymorale 
    instead of passing self.locations, pass the directory to use
    handleIcons(cordovaProject.projectConfig, self.locations.xcodeCordovaProj);
    handleSplashScreens(cordovaProject.projectConfig, 
self.locations.xcodeCordovaProj);
    
    then no need to do basename or create new variable originalName



> [iOS] icon and splashscreen images don't copy over correctly from template
> --------------------------------------------------------------------------
>
>                 Key: CB-10162
>                 URL: https://issues.apache.org/jira/browse/CB-10162
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master
>         Environment: iOS
>            Reporter: Edna Morales
>            Assignee: Edna Morales
>
> When specifying paths for splashscreen and icon images in config.xml, they do 
> not get copied over to the iOS project due to incorrect paths in the prepare 
> script for iOS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to