[
https://issues.apache.org/jira/browse/CB-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047970#comment-15047970
]
ASF GitHub Bot commented on CB-10162:
-------------------------------------
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/182#discussion_r47048171
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig,
locations) {
return Q();
}
-function handleIcons(projectConfig, platformRoot) {
+function handleIcons(projectConfig, platformRoot, locations) {
var icons = projectConfig.getIcons('ios');
- var appRoot = projectConfig.path;
+ var appRoot = path.dirname(projectConfig.path);
+ var originalName = path.basename(locations.xcodeCordovaProj);
--- End diff --
no need to create a new variable originalName or add 3rd parameter, use the
value already provided here self.locations.xcodeCordovaProj
> [iOS] icon and splashscreen images don't copy over correctly from template
> --------------------------------------------------------------------------
>
> Key: CB-10162
> URL: https://issues.apache.org/jira/browse/CB-10162
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: Master
> Environment: iOS
> Reporter: Edna Morales
> Assignee: Edna Morales
>
> When specifying paths for splashscreen and icon images in config.xml, they do
> not get copied over to the iOS project due to incorrect paths in the prepare
> script for iOS
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
