[
https://issues.apache.org/jira/browse/CB-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075280#comment-15075280
]
Patrick Mueller commented on CB-10281:
--------------------------------------
Thanks for the PR. Coupla things:
* the source is CoffeeScript; the original source location of your modification
is here:
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/weinre.coffee#L139
* weinre already handles CORS requests for things that CORS requests are
absolutely required for; see:
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/HttpChannelHandler.coffee#L46
and
https://github.com/apache/cordova-weinre/blob/master/weinre.server/lib-src/HttpChannelHandler.coffee#L141
So, not sure what this patch would do - presumably allow downloading of the
weinre static resources via CORS - the existing code just handles XHR requests
via CORS. Is there some reason you need this?
> Allow CORS
> ----------
>
> Key: CB-10281
> URL: https://issues.apache.org/jira/browse/CB-10281
> Project: Apache Cordova
> Issue Type: New Feature
> Components: weinre
> Affects Versions: 3.5.0
> Reporter: Miquel
> Assignee: Patrick Mueller
> Priority: Minor
> Labels: easyfix, features, patch
> Fix For: Master
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I've created a pull request to allow CORS:
> https://github.com/apache/cordova-weinre/pull/10:
> {noformat}
> diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
> index a4ca11c..036df78 100644
> --- a/weinre.server/lib/weinre.js
> +++ b/weinre.server/lib/weinre.js
> @@ -133,6 +133,11 @@ startServer = function() {
> });
> app.use(express.favicon(favIcon));
> app.use(jsonBodyParser());
> + app.use(function(req, res, next) {
> + res.header("Access-Control-Allow-Origin", "*");
> + res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
> Content-Type, Accept");
> + next();
> + });
> app.all(/^\/ws\/client(.*)/, function(request, response, next) {
> var uri;
> uri = request.params[0];
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
