[
https://issues.apache.org/jira/browse/CB-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076168#comment-15076168
]
Patrick Mueller commented on CB-10281:
--------------------------------------
I don't understand your description. What file can you not download with the
standard weinre, but can with your CORS changes? I'm trying to understand if
this is something everyone needs, if it's a safe change to make, etc.
In terms of the actual changes, I can make them, no worries. Just wanted to
point out where the actual source was.
> Allow CORS
> ----------
>
> Key: CB-10281
> URL: https://issues.apache.org/jira/browse/CB-10281
> Project: Apache Cordova
> Issue Type: New Feature
> Components: weinre
> Affects Versions: 3.5.0
> Reporter: Miquel
> Assignee: Patrick Mueller
> Priority: Minor
> Labels: easyfix, features, patch
> Fix For: Master
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I've created a pull request to allow CORS:
> https://github.com/apache/cordova-weinre/pull/10:
> {noformat}
> diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
> index a4ca11c..036df78 100644
> --- a/weinre.server/lib/weinre.js
> +++ b/weinre.server/lib/weinre.js
> @@ -133,6 +133,11 @@ startServer = function() {
> });
> app.use(express.favicon(favIcon));
> app.use(jsonBodyParser());
> + app.use(function(req, res, next) {
> + res.header("Access-Control-Allow-Origin", "*");
> + res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
> Content-Type, Accept");
> + next();
> + });
> app.all(/^\/ws\/client(.*)/, function(request, response, next) {
> var uri;
> uri = request.params[0];
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
