[
https://issues.apache.org/jira/browse/CB-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105213#comment-15105213
]
ASF GitHub Bot commented on CB-10326:
-------------------------------------
GitHub user biasmv opened a pull request:
https://github.com/apache/cordova-windows/pull/139
don't copy resource-files at plugin install
Instead, reference the file in the plugin directory. This allows to have
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g.
architecture.
This implements a fix for CB-10326
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/biasmv/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit e3425d97fd6bdd23823ba5430dca780405e803f6
Author: Marco Biasini <[email protected]>
Date: 2016-01-18T10:24:29Z
don't copy resource-files at plugin install
Instead, reference the file in the plugin directory. This allows to have
multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g.
architecture.
This implements a fix for CB-10326
----
> don't copy resource-file files at plugin install time
> -----------------------------------------------------
>
> Key: CB-10326
> URL: https://issues.apache.org/jira/browse/CB-10326
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Marco Biasini
>
> I just came across the newly added resource-file support for phonegap for
> windows. I've tried to use it for adding native dlls dependencies to the
> application. I couldn't completely get it to work with the current version.
> I'd like to propose a small change which would make the resource-file tag
> more powerful and shouldn't impact existing users:
> Judging from the source code, the file is copied to the target when the
> plugin is installed. I'd propose not to copy to the target but to point the
> include parameter to the existing file. This allows use-cases where a
> different .dll has to be copied based on the architecture of the project,
> .e.g.
> <resource-file src="x86/foo.dll" arch="x86" />
> <resource-file src="arm/foo.dll" arch="arm" />
> <resource-file src="x64/foo.dll" arch="x64" />
> This should generate code like this for each resource-file entry:
> <ItemGroup>
> <Content Condition="'$(Platform)'=='x86'" Include="x86/foo.dll">
> <Link>foo.dll</Link>
> <CopyToOutputDirectory>Always</CopyToOutputDirectory>
> </Content>
> </ItemGroup>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
