[
https://issues.apache.org/jira/browse/CB-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140616#comment-15140616
]
ASF GitHub Bot commented on CB-10518:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/383
CB-10518 Correct log level and error messages for some cordova errors
Issue [CB-10518](https://issues.apache.org/jira/browse/CB-10518)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10518
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #383
----
commit 6ab2d67aa6d428c8f0214e75c43974a5cd483a7b
Author: Vladimir Kotikov <[email protected]>
Date: 2016-02-10T10:44:46Z
CB-10518 Correct log level and error messages for some cordova errors
----
> Cordova reports error events with incorrect log level
> -----------------------------------------------------
>
> Key: CB-10518
> URL: https://issues.apache.org/jira/browse/CB-10518
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.0.0
> Reporter: Vladimir Kotikov
> Priority: Minor
> Labels: triaged
>
> In case of fatal errors {{cordova run}} and {{cordova emulate}} methods emit
> error messages using {{log}} event. This code probably should be changed to
> use 'warn' level. (We can't use 'error' here due to its special meaning in
> Node: https://nodejs.org/api/events.html#events_error_events)
> There is also other places, where 'log' events is used incorrectly:
> cordova-lib\src\cordova\targets.js: events.emit('log', 'An unexpected
> error has occured');
> cordova-lib\src\plugman\browserify.js: events.emit('log', 'error while
> generating cordova.js');
> cordova-lib\src\plugman\browserify.js: events.emit('log', 'Error
> running platform version script');
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
