[
https://issues.apache.org/jira/browse/CB-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145232#comment-15145232
]
ASF GitHub Bot commented on CB-10518:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/383#discussion_r52793854
--- Diff: cordova-lib/src/cordova/compile.js ---
@@ -40,7 +40,7 @@ module.exports = function compile(options) {
}).then(function() {
return hooksRunner.fire('after_compile', options);
}, function(error) {
- events.emit('log', 'ERROR building one of the platforms: ' + error
+ '\nYou may not have the required environment or OS to build this project');
+ events.emit('warn', 'ERROR building one of the platforms: ' +
error + '\nYou may not have the required environment or OS to build this
project');
--- End diff --
I'm not sure if we should continue emitting message here at all, because it
is not consistent with other similar places, e.g. but `build` and `emulate` do
not emit this message. Also the message is not very informative, as `compile`
might fail due to a lot of different reasons.
In general for cases like this, when initial error message might not be
very descriptive, i'd rather reject a promise with (or throw in case of sync
code) a new `CordovaError` with appropriate message and original error object,
attached.
> Cordova reports error events with incorrect log level
> -----------------------------------------------------
>
> Key: CB-10518
> URL: https://issues.apache.org/jira/browse/CB-10518
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.0.0
> Reporter: Vladimir Kotikov
> Priority: Minor
> Labels: triaged
>
> In case of fatal errors {{cordova run}} and {{cordova emulate}} methods emit
> error messages using {{log}} event. This code probably should be changed to
> use 'warn' level. (We can't use 'error' here due to its special meaning in
> Node: https://nodejs.org/api/events.html#events_error_events)
> There is also other places, where 'log' events is used incorrectly:
> cordova-lib\src\cordova\targets.js: events.emit('log', 'An unexpected
> error has occured');
> cordova-lib\src\plugman\browserify.js: events.emit('log', 'error while
> generating cordova.js');
> cordova-lib\src\plugman\browserify.js: events.emit('log', 'Error
> running platform version script');
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
