[
https://issues.apache.org/jira/browse/CB-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151395#comment-15151395
]
ASF GitHub Bot commented on CB-10640:
-------------------------------------
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/151#discussion_r53248411
--- Diff: template/cordova/lib/log.js ---
@@ -47,10 +47,10 @@ var appTracingInitialState = null,
* and prints them to console
*/
module.exports.run = function(args) {
- var startTime = new Date(new Date().getTime() - 10 * 60 *
1000).toISOString(), // show last 10 minutes by default
- knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' :
Boolean },
- shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
- parsedOpts = nopt(knownOpts, shortHands, args, 0);
+ var logFromTime = 10 * 60 * 1000; // show last 10 minutes by default
--- End diff --
Might be useful to define `ONE_MINUTE` and then just say `10 * ONE_MINUTE`
or `parsedOpts.minutes * ONE_MINUTE`, in order to avoid duplication of `60 *
1000`.
> Windows logging is broken
> -------------------------
>
> Key: CB-10640
> URL: https://issues.apache.org/jira/browse/CB-10640
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Sarangan Rajamanickam
> Assignee: Sarangan Rajamanickam
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
