[ 
https://issues.apache.org/jira/browse/CB-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151515#comment-15151515
 ] 

ASF GitHub Bot commented on CB-10640:
-------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/151#discussion_r53257649
  
    --- Diff: template/cordova/lib/log.js ---
    @@ -151,23 +154,23 @@ function exitGracefully(exitCode) {
     }
     
     function startLogging(channel) {
    -    var startTime = new Date().toISOString();
    +    var logFromTime = 10 * ONE_MINUTE;
    --- End diff --
    
    This is set to the default value twice, [here][case1] and [there][case2], 
how come?
    
    [case1]: 
https://github.com/apache/cordova-windows/pull/151/files#diff-378bd5207000848de6b771d61b037e2fR157
    [case2]: 
https://github.com/apache/cordova-windows/pull/151/files#diff-378bd5207000848de6b771d61b037e2fR53


> Windows logging is broken
> -------------------------
>
>                 Key: CB-10640
>                 URL: https://issues.apache.org/jira/browse/CB-10640
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Sarangan Rajamanickam
>            Assignee: Sarangan Rajamanickam
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to