[
https://issues.apache.org/jira/browse/CB-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210006#comment-15210006
]
ASF GitHub Bot commented on CB-10942:
-------------------------------------
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-200759257
Tested and working fine
I think the first if can be removed
```
if (allowNavigationsPass && allowIntentPass) {
return CDVIntentAndNavigationFilterValueNavigationAllowed;
}```
This one is enough
```
if (allowNavigationsPass) {
return CDVIntentAndNavigationFilterValueNavigationAllowed;
}```
> Cannot <allow-navigation href="https://foo.bar"; /> for links in that site, if
> you have <allow-intent href="https://*"; />
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-10942
> URL: https://issues.apache.org/jira/browse/CB-10942
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> https://github.com/apache/cordova-ios/blob/6221bd7c7f54421a158cd18d1ecb8ee88247db07/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L74
> 1. Re-factor that method so it is testable
> 2. Add Obj-C tests to test this case
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
