[
https://issues.apache.org/jira/browse/CB-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212711#comment-15212711
]
ASF GitHub Bot commented on CB-10942:
-------------------------------------
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-201656326
I put that conditional in on purpose, to be explicit in the code what the
rules are (I know the comment is in there as well) "unoptimized", it should be
fine since algorithmically it doesn't add any complexity imo
> Cannot <allow-navigation href="https://foo.bar"; /> for links in that site, if
> you have <allow-intent href="https://*"; />
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-10942
> URL: https://issues.apache.org/jira/browse/CB-10942
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> https://github.com/apache/cordova-ios/blob/6221bd7c7f54421a158cd18d1ecb8ee88247db07/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L74
> 1. Re-factor that method so it is testable
> 2. Add Obj-C tests to test this case
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
