[
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252610#comment-15252610
]
ASF GitHub Bot commented on CB-11136:
-------------------------------------
GitHub user ephemer opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162
CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView
thread
Presenting a UIViewController in front of the main Cordova UIViewController
containing a WKWebView causes the WKWebView thread to block entirely. This
means that the OAuth login flow pauses on a blank screen on success, which is
bad for the user experience that falsely looks like an error has on occurred.
See https://issues.apache.org/jira/browse/CB-11136 for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ephemer/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit 04091fde737519c149e7ad6316971cb6b490c5b3
Author: Geordie J <[email protected]>
Date: 2016-04-21T20:22:38Z
CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView
thread
----
> InAppBrowser fails to close with WKWebView OAuth
> -------------------------------------------------
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin InAppBrowser, Plugin WKWebViewEngine
> Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
> Reporter: Geordie Jay
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another
> view controller is presented. This can be confirmed by inspecting the
> WKWebView session in Safari, running `window.open('http://something.com')`
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the
> InAppBrowser's view manually, rather than 'presenting' the ViewController in
> the traditional iOS style. In that instance the WKWebView thread continues as
> normal and receives the confirmation to close the other InAppBrowser when the
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the
> InAppBrowser acceptable? Would be happy to make a pull request along these
> lines if it is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
