[
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252749#comment-15252749
]
ASF GitHub Bot commented on CB-11136:
-------------------------------------
Github user jcesarsh commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/162#issuecomment-213116268
I don't think it's a good idea to switch from presenting a modal view to
adding a subview, it might behave differently in some cases.
Maybe adding a new "modal" option being "yes" as default so users will have
the same behavior and the ones with CB-11136 problem can use the "modal=no"
> InAppBrowser fails to close with WKWebView OAuth
> -------------------------------------------------
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin InAppBrowser, Plugin WKWebViewEngine
> Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
> Reporter: Geordie Jay
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another
> view controller is presented. This can be confirmed by inspecting the
> WKWebView session in Safari, running `window.open('http://something.com')`
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the
> InAppBrowser's view manually, rather than 'presenting' the ViewController in
> the traditional iOS style. In that instance the WKWebView thread continues as
> normal and receives the confirmation to close the other InAppBrowser when the
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the
> InAppBrowser acceptable? Would be happy to make a pull request along these
> lines if it is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
