[
https://issues.apache.org/jira/browse/CB-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321160#comment-15321160
]
Soeren Unruh commented on CB-11391:
-----------------------------------
Pull request [https://github.com/apache/cordova-plugin-whitelist/pull/20] is
breaking plugin in case {{shouldAllowNavigation()}} returns {{null}}:
{code}
E/AndroidRuntime( 5192): java.lang.NullPointerException
E/AndroidRuntime( 5192): at
org.apache.cordova.whitelist.WhitelistPlugin.shouldAllowRequest(WhitelistPlugin.java:121)
E/AndroidRuntime( 5192): at
org.apache.cordova.PluginManager.shouldAllowRequest(PluginManager.java:348)
E/AndroidRuntime( 5192): at
org.apache.cordova.engine.SystemWebViewClient.shouldInterceptRequest(SystemWebViewClient.java:325)
E/AndroidRuntime( 5192): at
android.webkit.CallbackProxy.shouldInterceptRequest(CallbackProxy.java:1126)
E/AndroidRuntime( 5192): at
android.webkit.BrowserFrame.shouldInterceptRequest(BrowserFrame.java:846)
E/AndroidRuntime( 5192): at
android.webkit.JWebCoreJavaBridge.nativeServiceFuncPtrQueue(Native Method)
E/AndroidRuntime( 5192): at
android.webkit.JWebCoreJavaBridge.handleMessage(JWebCoreJavaBridge.java:113)
E/AndroidRuntime( 5192): at
android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 5192): at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime( 5192): at
android.webkit.WebViewCore$WebCoreThread.run(WebViewCore.java:834)
E/AndroidRuntime( 5192): at java.lang.Thread.run(Thread.java:856)
{code}
> cordova-plugin-whitelist Android does not pass sonarqube scan
> -------------------------------------------------------------
>
> Key: CB-11391
> URL: https://issues.apache.org/jira/browse/CB-11391
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Whitelist
> Affects Versions: Master
> Environment: Android
> Reporter: Rob Close
> Priority: Minor
> Fix For: Master
>
>
> The Android whitelist plugin does not pass sonarqube
> (http://www.sonarqube.org/) scan.
> The problem is "Correctness - Suspicious reference comparison of Boolean
> values", which sonarqube considers major.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
