[
https://issues.apache.org/jira/browse/CB-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322736#comment-15322736
]
ASF subversion and git services commented on CB-11391:
------------------------------------------------------
Commit ab36e6d19b3e1d6b6e24562cdb43980ef9d02df6 in cordova-plugin-whitelist's
branch refs/heads/master from [~rclose]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-whitelist.git;h=ab36e6d
]
CB-11391 Revert c2c0072 android: Does not pass sonarqube scan
Originaly was trying to correct this sonarqube complaint:
"Correctness - Suspicious reference comparison of Boolean values"
I failed to notice that the condition can be one of three states:
true, false, or null.
The original code was valid. Undoing my change.
This closes #21
> cordova-plugin-whitelist Android does not pass sonarqube scan
> -------------------------------------------------------------
>
> Key: CB-11391
> URL: https://issues.apache.org/jira/browse/CB-11391
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Whitelist
> Affects Versions: Master
> Environment: Android
> Reporter: Rob Close
> Priority: Minor
> Fix For: Master
>
>
> The Android whitelist plugin does not pass sonarqube
> (http://www.sonarqube.org/) scan.
> The problem is "Correctness - Suspicious reference comparison of Boolean
> values", which sonarqube considers major.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]