[
https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348723#comment-15348723
]
ASF GitHub Bot commented on CB-11412:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/458
## [Current coverage][cc-pull] is **80.59%**
> Merging [#458][cc-pull] into [master][cc-base-branch] will increase
coverage by **0.01%**
```diff
@@ master #458 diff @@
==========================================
Files 68 68
Lines 5377 5380 +3
Methods 851 851
Messages 0 0
Branches 1039 1038 -1
==========================================
+ Hits 4333 4336 +3
Misses 1044 1044
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by
[0c6f88d...086c991][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/cordova-lib/compare/0c6f88d2b136cf78ce57f323b75600a9b284e58a...086c9913682cd82d1d364621f4dfa8322985e263
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/458?src=pr
> Update template implementation in cordova create --template
> -----------------------------------------------------------
>
> Key: CB-11412
> URL: https://issues.apache.org/jira/browse/CB-11412
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Caryn Tran
> Assignee: Caryn Tran
>
> https://github.com/cordova/cordova-discuss/pull/49
> Sometimes we do want a `package.json` copied over. `package.json` could have
> build scripts that are essential for the template to work. To handle this use
> case, template authors are suggested to put template files in a subdirectory
> and point to that subdirectory in index.js. All files in the subdirectory are
> copied over.
> Update the current template implementation to ignore the list of files above
> that shouldn't be copied over when using `--template`. If a subdirectory is
> used, copy the entire contents of the subdirectory.
> If a `package.json` exists in the subdirectory, we should update its fields
> like we do to `config.xml`.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
> Only field to update in `package.json` should be `package.name`.
> `package.name` should be updated to use `config.name` lowercased (npm package
> names have to be lowercase). `config.name` is the optional third argument
> `cordova create` takes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
