[
https://issues.apache.org/jira/browse/CB-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352209#comment-15352209
]
ASF GitHub Bot commented on CB-11270:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/232
## [Current coverage][cc-pull] is **51.81%**
> Merging [#232][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@ master #232 diff @@
==========================================
Files 11 11
Lines 882 882
Methods 132 132
Messages 0 0
Branches 143 143
==========================================
Hits 457 457
Misses 425 425
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by
[7d99390...58b13f8][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/cordova-ios/compare/7d993909d7274d6d22c77645491da6e5e5188eda...58b13f8f99ed10f05f685d2df40c231a5c42a4c0
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/232?src=pr
> [QUESTION] Is whitelist intent filter working as intended?
> ----------------------------------------------------------
>
> Key: CB-11270
> URL: https://issues.apache.org/jira/browse/CB-11270
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS
> Reporter: Tony Homer
> Assignee: Shazron Abdullah
>
> In 3.8.0, given an intent directive like
> {code}
> <allow-intent href="tel:*" />
> {code}
> , interacting with any of the following elements would result in tel:
> requests that would all be allowed:
> {code}
> <a id="tel-button" href="tel:777777777">do tel with a.href</a>
> <a id="tel-a-onclick" onclick="document.location.href='tel:777777777';">do
> tel with a.onclick</a>
> <button id="tel-button" onclick="document.location.href='tel:777777777';">do
> tel with button.onclick</button>
> {code}
> However, in 4.1.1, only the first interaction will be allowed.
> This is because intent directives are only applied to the
> UIWebViewNavigationTypeLinkClicked navigationType (the navigationType for the
> second and third examples is UIWebViewNavigationTypeOther).
> Is this working as intended?
> It seems that either the whitelist intent filter in 4+ is not working as
> intended or, if working as intended, the documentation should be improved to
> spell out this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
