[
https://issues.apache.org/jira/browse/CB-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403927#comment-15403927
]
ASF GitHub Bot commented on CB-11652:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/475
CB-11652 Update run and emulate to skip build
This PR moves handling of `--nobuild` option to CLI. CLI previously has
delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call platform's
`build` and `run` separately and now need to handle this option here.
JIRA issue: [CB-11652](https://issues.apache.org/jira/browse/CB-11652)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-11652
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #475
----
commit 9e4bc845e8d86e174a992a514d9b2292bdda74f1
Author: Vladimir Kotikov <[email protected]>
Date: 2016-08-02T12:08:24Z
CB-11652 Update run and emulate to skip build
We need to add this conditional logic to cordova's `run` and
`emulate` methods to skip build when `--nobuild` option is
specified. CLI previously has delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call
platform's `build` and `run` separately and so we need to handle
this option in CLI
----
> cordova run ignores --nobuild option
> ------------------------------------
>
> Key: CB-11652
> URL: https://issues.apache.org/jira/browse/CB-11652
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.3.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: reproduced, triaged
> Fix For: 6.3.1
>
>
> Since 6.3.0 {{cordova run windows --nobuild}} ignores {{-nobuild}} option and
> always builds the project. Please note that this is actual for other
> platforms too.
> {noformat}
> cordova run windows --nobuild
> Warning: using prerelease version 6.3.1-dev ([email protected])
> Building project:
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform : anycpu
> CordovaApp.Windows ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> CordovaApp.Windows ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug.appxupload
> Your package has been successfully created.
> Building project:
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform : anycpu
> CordovaApp.Phone ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug_Test\CordovaApp.Phone_1.0.0.0_anycpu_debug.appx
> CordovaApp.Phone ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug.appxupload
> Your package has been successfully created.
> Deploying windows package to device:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Attempting to uninstall previous application version...
> Attempting to install application...
> Found package:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Installing app...
> Found dependency package(s):
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\Dependencies\Microsoft.WinJS.2.0.appx
> Success: Your app was successfully installed.
> Starting application...
> ActivateApplication:
> io.cordova.hellocordova_h35559jr9hy9m!io.cordova.hellocordova
> {noformat}
> This was introduced by CB-11491
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
