[
https://issues.apache.org/jira/browse/CB-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403951#comment-15403951
]
ASF GitHub Bot commented on CB-11652:
-------------------------------------
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/475#discussion_r73153070
--- Diff: cordova-lib/src/cordova/emulate.js ---
@@ -42,20 +46,17 @@ module.exports = function emulate(options) {
}).then(function() {
// Deploy in parallel (output gets intermixed though...)
return Q.all(options.platforms.map(function(platform) {
- // This is needed as .build modifies opts
- var optsClone = _.clone(options.options);
- return platform_lib
- .getPlatformApi(platform)
- .build(options.options)
- .then(function() {
- return hooksRunner.fire('before_deploy', options);
- })
- .then(function() {
- optsClone.nobuild = true;
- return platform_lib
- .getPlatformApi(platform)
- .run(optsClone);
- });
+
+ var emulatePromise = options.options.nobuild ? Q() :
--- End diff --
Should this also be called `buildPromise`?
> cordova run ignores --nobuild option
> ------------------------------------
>
> Key: CB-11652
> URL: https://issues.apache.org/jira/browse/CB-11652
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.3.0
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
> Labels: reproduced, triaged
> Fix For: 6.3.1
>
>
> Since 6.3.0 {{cordova run windows --nobuild}} ignores {{-nobuild}} option and
> always builds the project. Please note that this is actual for other
> platforms too.
> {noformat}
> cordova run windows --nobuild
> Warning: using prerelease version 6.3.1-dev ([email protected])
> Building project:
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
> Configuration : debug
> Platform : anycpu
> CordovaApp.Windows ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> CordovaApp.Windows ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug.appxupload
> Your package has been successfully created.
> Building project:
> D:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Phone.jsproj
> Configuration : debug
> Platform : anycpu
> CordovaApp.Phone ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug_Test\CordovaApp.Phone_1.0.0.0_anycpu_debug.appx
> CordovaApp.Phone ->
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Phone_1.0.0.0_anycpu_debug.appxupload
> Your package has been successfully created.
> Deploying windows package to device:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Attempting to uninstall previous application version...
> Attempting to install application...
> Found package:
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\CordovaApp.Windows_1.0.0.0_anycpu_debug.appx
> Installing app...
> Found dependency package(s):
> D:\PROJECTS\Temp\foo\platforms\windows\AppPackages\CordovaApp.Windows_1.0.0.0_anycpu_debug_Test\Dependencies\Microsoft.WinJS.2.0.appx
> Success: Your app was successfully installed.
> Starting application...
> ActivateApplication:
> io.cordova.hellocordova_h35559jr9hy9m!io.cordova.hellocordova
> {noformat}
> This was introduced by CB-11491
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
