[ 
https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440159#comment-15440159
 ] 

ASF GitHub Bot commented on CB-11776:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/486
  
    ## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) is 80.78% 
(diff: 100%)
    > Merging [#486](https://codecov.io/gh/apache/cordova-lib/pull/486?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage
    
    ```diff
    @@             master       #486   diff @@
    ==========================================
      Files            68         68          
      Lines          5407       5407          
      Methods         857        857          
      Messages          0          0          
      Branches       1048       1048          
    ==========================================
      Hits           4368       4368          
      Misses         1039       1039          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update 
[3b38b53...a7e6634](https://codecov.io/gh/apache/cordova-lib/compare/3b38b5382b9a52d1fe522514b61d3ebd6016796d...a7e6634217e187434d560ac2d32bf352662b3a25?src=pr)


> Can't add two plugins with different edit-config targets
> --------------------------------------------------------
>
>                 Key: CB-11776
>                 URL: https://issues.apache.org/jira/browse/CB-11776
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: CordovaCommon
>    Affects Versions: 1.4.0
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: edit-config
>             Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second 
> plugin will have issues being added. The conflict checking for edit-config is 
> missing a case where the target cannot resolve to an existing target. Should 
> check if the target exists before proceeding. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to